Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds integration test for date archive builder. #21392

Merged
merged 2 commits into from
May 27, 2024

Conversation

thijsoo
Copy link
Contributor

@thijsoo thijsoo commented May 17, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Adds integration tests to the date archive indexable builder.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@thijsoo thijsoo added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 17, 2024
@thijsoo thijsoo linked an issue May 17, 2024 that may be closed by this pull request
@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build a1cc2a5e06854c0b80b9193cb7d623f4c93e0f88

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 52.604%

Totals Coverage Status
Change from base Build 9092209d55aa5a8e5ebf33e771925ce9dfb32d9e: 0.0%
Covered Lines: 28300
Relevant Lines: 54409

💛 - Coveralls

Copy link
Contributor

@leonidasmi leonidasmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR is 👍

@leonidasmi leonidasmi changed the base branch from feature/plugin-fixes to trunk May 27, 2024 09:37
@leonidasmi leonidasmi force-pushed the 21390-add-integration-test-to-date-archive-builder branch from 4a4d868 to caf19a3 Compare May 27, 2024 09:38
@leonidasmi leonidasmi changed the base branch from trunk to feature/plugin-fixes May 27, 2024 09:45
@leonidasmi leonidasmi changed the base branch from feature/plugin-fixes to trunk May 27, 2024 09:45
@leonidasmi leonidasmi force-pushed the 21390-add-integration-test-to-date-archive-builder branch from caf19a3 to 003e680 Compare May 27, 2024 09:57
@leonidasmi leonidasmi added this to the 22.8 milestone May 27, 2024
@leonidasmi leonidasmi merged commit e258f00 into trunk May 27, 2024
23 checks passed
@leonidasmi leonidasmi deleted the 21390-add-integration-test-to-date-archive-builder branch May 27, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration test to date archive builder
3 participants