Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some flags have rx="-1" (negative border radius) which causes a crash in react-native-svg and some other renderers #73

Open
2 of 3 tasks
SimpleCreations opened this issue Jun 6, 2022 · 1 comment

Comments

@SimpleCreations
Copy link

Some flags, such as this one
https://github.com/Yummygum/flagpack-core/blob/main/lib/flags/s/DEU.svg

have rx="-1" declared on a <rect> element, which causes a crash in react-native-svg.

Here is the list of flags in the s directory that have this:

./008.svg
./276.svg
./466.svg
./496.svg
./540.svg
./584.svg
./659.svg
./728.svg
./800.svg
./AL.svg
./ALB.svg
./DE.svg
./DEU.svg
./KN.svg
./KNA.svg
./MH.svg
./MHL.svg
./ML.svg
./MLI.svg
./MN.svg
./MNG.svg
./NC.svg
./NCL.svg
./SS.svg
./SSD.svg
./UG.svg
./UGA.svg

Please check all that apply

  • visual bug
  • functional bug
  • able to consistently reproduce

Possible Solution

Remove rx="-1" as it does not serve any purpose anyway.

@CramericaIndustries
Copy link

rx="-1" is an invalid value according to the svg spec

A negative value for rx is invalid and must be ignored.

https://svgwg.org/svg2-draft/geometry.html#RX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants