Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect documentation for check_point_order_equals_group_order #167

Open
tjade273 opened this issue Jul 20, 2022 · 2 comments · May be fixed by #178
Open

Incorrect documentation for check_point_order_equals_group_order #167

tjade273 opened this issue Jul 20, 2022 · 2 comments · May be fixed by #178

Comments

@tjade273
Copy link

In the documentation for check_point_order_equals_group_order,

curv/src/elliptic/curves/traits.rs

Line 185 in 44537a7

/// P ≠ 0 ∧ qP ≠ 0

should presumably read

/// P ≠ 0 ∧ qP = 0

The implementation appears to be correct, so just a simple doc fix should suffice.
@tjade273
Copy link
Author

In addition,

curv/src/elliptic/curves/bls12_381/g2.rs

Line 249 in 44537a7

/// Converts message to G1 point.

should say G2 instead of G1

@leontiadZen
Copy link
Contributor

Thanks @tjade273 , feel free to open a PR :)

@tjade273 tjade273 linked a pull request Mar 29, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix minor documentation typos tjade273/curv
2 participants
@tjade273 @leontiadZen