Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deterministic / regression unit testing for elliptic curves #65

Open
gbenattar opened this issue Sep 8, 2019 · 2 comments
Open

Deterministic / regression unit testing for elliptic curves #65

gbenattar opened this issue Sep 8, 2019 · 2 comments

Comments

@gbenattar
Copy link
Contributor

Motivation

Curv is used as a low level library for crypto-currency wallets impacting the following critical features: address creation / derivation, master-key generation, signature.
A framework for unit testing a curve should be defined and used.

Proposal

As a starting point, my proposal is to start with secp256 and add basic unit testing which make sure of basic features. Test output against previously verified hardcoded set of values.

@Silur
Copy link

Silur commented Sep 8, 2019

If there's any plan to implement other curves as well, then I'd go with the methodology seen at https://github.com/openssl/openssl/blob/master/test/ectest.c and don't make tests curve-specific.

@omershlo
Copy link
Contributor

omershlo commented Sep 8, 2019

Can you elaborate more please on this methodology and when it should be applied ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants