Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It fails on test top level domains #11

Open
annard opened this issue Jul 23, 2020 · 3 comments
Open

It fails on test top level domains #11

annard opened this issue Jul 23, 2020 · 3 comments

Comments

@annard
Copy link

annard commented Jul 23, 2020

Given the list of domains noted in this wikipedia article domainatrex fails during our tests on "x.test" or "x.invalid" or x.example". These may not be used in the wider internet but they are valid domain names.

@bortzmeyer
Copy link

The problem is that these names are not in the Public Suffix List. Reading the documentation of the PSL, I do not find a clear specification on what should be done with domains not found in the PSL. I assume it is application-specific. May be Domainatrex should return a different value for "not found"?

@qannard
Copy link

qannard commented Apr 6, 2023

You could not check the public suffix list at all and just return :ok as these are valid domains. So do a pre-check to bypass it?

@Zensavona
Copy link
Owner

Hi @qannard - I'd be open to a PR which adds a new config option called allow_test which defaults to false, but the intended behaviour is to fail on domains which aren't in the public suffix list, which I believe is what is happening here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants