Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] v1.3.9 plan: add emojiAlign | add alias #43

Closed
2 tasks done
Zhengqbbb opened this issue Jun 29, 2022 · 9 comments
Closed
2 tasks done

[Feature Request] v1.3.9 plan: add emojiAlign | add alias #43

Zhengqbbb opened this issue Jun 29, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request next version Plan for next version

Comments

@Zhengqbbb
Copy link
Owner

Zhengqbbb commented Jun 29, 2022

💭 Describe the feature

  • add emojiAlign support emoji is placed before type
  • add alias to directly output the defined commit message

💡 Proposed Solution

Add emojiAlign

support emoji is placed before type
The format alignment is really nice, but considering the validation with following Angular commit, the default is center

  • type: "left" | "center" | "right"

image


Add alias

We may encounter commit messages that are often output, such as docs: fix typos, if we define like.

{
 "alias": {
     "df": "docs: fix typos"
  }
}

Usage:

  1. czg :df
  2. czg --alias="df"
  3. cz_alias="df" git cz
  4. cz_alias="df" cz

You can directly output docs: fix typos commit message
It will be awesome and convenient.

@Zhengqbbb Zhengqbbb added the enhancement New feature or request label Jun 29, 2022
@Zhengqbbb Zhengqbbb self-assigned this Jun 29, 2022
@Zhengqbbb Zhengqbbb changed the title [Feature Request] add emojiAlign support emoji is placed before type [Feature Request] add emojiAlign Jun 29, 2022
@Zhengqbbb Zhengqbbb added the next version Plan for next version label Jun 29, 2022
@Zhengqbbb
Copy link
Owner Author

But I'm not sure if this options name is good
@chrisbbreuer @jaklan If have time, can help me check together. I will appreciate it.

@Zhengqbbb Zhengqbbb changed the title [Feature Request] add emojiAlign [Feature Request] v1.3.9 plan: add emojiAlign Jun 29, 2022
@jaklan
Copy link
Contributor

jaklan commented Jun 29, 2022

@Zhengqbbb "emojiAlign" sounds pretty fine for me. Can you show some examples of all 3 options: "left", "center", "right"? I'm not sure how to interpret "center".

@Zhengqbbb
Copy link
Owner Author

@Zhengqbbb "emojiAlign" sounds pretty fine for me. Can you show some examples of all 3 options: "left", "center", "right"? I'm not sure how to interpret "center".

Yep, the "center" expression not good.

default:center
wecom-temp-7cd4d7ef6183ab9ccb902abe83eeae20
left:
wecom-temp-594d5698b5368dbb01ba561f31ad1161
right:
wecom-temp-23a04ada9e31c4b560f18be8ae4af2d6

@jaklan
Copy link
Contributor

jaklan commented Jun 29, 2022

I see, that's what I assumed, just wanted to make sure 🙂 If you provide examples in docs, imho center is okay - any other word can be even more confusing.

@Zhengqbbb
Copy link
Owner Author

I see, that's what I assumed, just wanted to make sure 🙂 If you provide examples in docs, imho center is okay - any other word can be even more confusing.

Thx~ 😊

@Zhengqbbb Zhengqbbb changed the title [Feature Request] v1.3.9 plan: add emojiAlign [Feature Request] v1.3.9 plan: add emojiAlign | add alias Jun 29, 2022
Zhengqbbb added a commit that referenced this issue Jun 29, 2022
Zhengqbbb added a commit that referenced this issue Jun 29, 2022
@chrisbbreuer
Copy link

chrisbbreuer commented Jun 29, 2022

Love the feature!

I would potentially think about the following naming adjustment:

emojiAlign -> emojiAlignment

We sparingly use the noun + imperative convention throughout the codebase. And it seems a little more clear because Align could indicate it accepts more than "just a string."

While this is just a minor adjustment, thanks for all the work ❤️

PS: the alias config seems like a great config item for the Stacks framework. Looking forward to implementing it!

@Zhengqbbb
Copy link
Owner Author

@chrisbbreuer

Thx~ 😊

Zhengqbbb added a commit that referenced this issue Jun 30, 2022
Zhengqbbb added a commit that referenced this issue Jun 30, 2022
@Zhengqbbb
Copy link
Owner Author

Zhengqbbb commented Jun 30, 2022

alias

czg --aliasdemo:
demo

Warning: Use Commitizen CLI like cz_alias=df cz. The proccess can't exit after commit. Because cz-cli not listening for Node.js close event, cz-git can't handle.
demo

Zhengqbbb added a commit that referenced this issue Jul 1, 2022
Zhengqbbb added a commit that referenced this issue Jul 1, 2022
`czg :fd`  || `czg --alias=fd` || `cz_alias=fd cz`
@Zhengqbbb
Copy link
Owner Author

⭐️ v1.3.9 ⭐️ has been released 🥳

Have a enjoy ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next version Plan for next version
Projects
None yet
Development

No branches or pull requests

3 participants