Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule warning level not respected #71

Closed
2 tasks done
JoaoEdu93 opened this issue Oct 16, 2022 · 3 comments
Closed
2 tasks done

Rule warning level not respected #71

JoaoEdu93 opened this issue Oct 16, 2022 · 3 comments
Assignees
@Zhengqbbb
Labels
bug Something isn't working next version Plan for next version

Comments

@JoaoEdu93
Copy link
Contributor

✅ Checklist

  • I am using the latest version
  • I have searched FAQ

📄 System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz
    Memory: 19.79 GB / 31.89 GB
  Binaries:
    Node: 16.14.2 - C:\Program Files\nodejs\node.EXE
    npm: 8.19.1 - C:\Program Files\nodejs\npm.CMD
  npmPackages:
    commitizen: ^4.2.5 => 4.2.5
    cz-git: ^1.3.11 => 1.3.11

🔎 Description

Description

In the file "commitlint.config.js" I have the rule "header-max-length" with the value 52 and with level 1 (warning).
When writing a header that exceeds 52 characters, it gives an error and won't let you proceed.

Expected behavior

It should display a warning message saying that the character limit has been exceeded, but it should let you proceed.

Screenshots

image

🔗 Reproduction link / repo:

No response
@JoaoEdu93 JoaoEdu93 added the bug Something isn't working label Oct 16, 2022
@Zhengqbbb Zhengqbbb added the next version Plan for next version label Oct 17, 2022
@Zhengqbbb
Copy link
Owner

Zhengqbbb commented Oct 17, 2022 •
edited

Big thx to provide the suggestion issue. 💪
The version 1.3.12-beta.1 have released. you can check and use it for now.

npm install -D cz-git@next

I will test and relesed in the weekend.

image

Zhengqbbb added a commit that referenced this issue Oct 17, 2022
@Zhengqbbb
fix(cz-git): add ignore commitlint warning max length rule
de8b5f7 
like `'subject-max-length': [1, 'always', 72]`
the array 1 mean warning.commitlint not prevent commit.
so that `cz-git` will just provide prompt expect words msg.

link #71

Co-authored-by: Zhengqbbb <1074059947@qq.com>
@JoaoEdu93
Copy link
Contributor Author

Thank you very much.
I've tried it out and it seems good. 👍

@Zhengqbbb Zhengqbbb mentioned this issue Oct 18, 2022
Merged
6 tasks
@Zhengqbbb
Copy link
Owner

The latest version 🌟(v1.3.12)🌟 should be resolve this issue request , please have a try. 💪
👀 Let me know if there are still any issues. Thanks for you work! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zhengqbbb Zhengqbbb

Labels
bug Something isn't working next version Plan for next version
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoaoEdu93 @Zhengqbbb