Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cz-git,czg): add ignore commitlint warning max length rule #72

Merged
merged 2 commits into from Oct 20, 2022
Merged

fix(cz-git,czg): add ignore commitlint warning max length rule #72

merged 2 commits into from Oct 20, 2022

Conversation

Zhengqbbb
Copy link
Owner

@Zhengqbbb Zhengqbbb commented Oct 18, 2022 •
edited

Related ISSUE

Input follow ISSUE URL address

#71

Type Of Change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 📝 Document (This change requires a documentation update)
  • 🎨 Theme style (Theme style beautification)
  • ⚠ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔨 Workflow (Workflow changes)

Clear Describe

A clear and concise description of what update for target.

  • fix(cz-git): add ignore commitlint warning max length rule

Description

Please enter detailed relevant motivation, background and implementation ... descriptive information.

In commitlint like 'subject-max-length': [1, 'always', 72]
the array 1 mean warning.commitlint not prevent commit.
so that cz-git will just provide prompt expect words msg.

Test Case

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test case.

image

@Zhengqbbb
style: update utils
02e03c5 
Co-authored-by: Zhengqbbb <1074059947@qq.com>
@Zhengqbbb
fix(cz-git): add ignore commitlint warning max length rule
de8b5f7 
like `'subject-max-length': [1, 'always', 72]`
the array 1 mean warning.commitlint not prevent commit.
so that `cz-git` will just provide prompt expect words msg.

link #71

Co-authored-by: Zhengqbbb <1074059947@qq.com>
@netlify
Copy link

netlify bot commented Oct 18, 2022 •
edited

✅ Deploy Preview for cz-git canceled.

Name Link
🔨 Latest commit de8b5f7
🔍 Latest deploy log https://app.netlify.com/sites/cz-git/deploys/634e74e2eebbc4000816a001

@Zhengqbbb Zhengqbbb merged commit 46346b4 into main Oct 20, 2022
@Zhengqbbb Zhengqbbb deleted the fix/ignore-strict-length_71 branch October 20, 2022 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Zhengqbbb