Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unlisted vimeo urls with parameters #116

Open
JannikApm opened this issue Nov 1, 2023 · 0 comments
Open

Support unlisted vimeo urls with parameters #116

JannikApm opened this issue Nov 1, 2023 · 0 comments

Comments

@JannikApm
Copy link

JannikApm commented Nov 1, 2023

Unlisted Vimeo links consist of the video ID and an additional hash: https://vimeo.com/[video_id]/[unlisted_hash]. More information about unlisted Vimeo links can be found here.

The problematic links I'm encountering are unlisted links with an additional URL parameter. Those are created when simply pressing the "share" button on an unlisted video's player.

Parsing the following link https://vimeo.com/12345678/abcdefg?share=copy returns

{
  "mediaType": "video",
  "params": {
    "share": "copy"
  },
  "id": "12345678",
  "provider": "vimeo"
}

While parsing https://vimeo.com/12345678/abcdefg returns

{
  "mediaType": "video",
  "params": {
    "hash": "abcdefg"
  },
  "id": "12345678",
  "provider": "vimeo"
}

Solution:
URL param and hash should probably be merged so that both are kept.

Expected return for https://vimeo.com/12345678/abcdefg?share=copy

{
  "mediaType": "video",
  "params": {
    "hash": "abcdefg",
    "share": "copy"
  },
  "id": "12345678",
  "provider": "vimeo"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant