Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo Live Stream Events shouldn't parse as videos #72

Open
rickpern opened this issue Nov 13, 2020 · 3 comments
Open

Vimeo Live Stream Events shouldn't parse as videos #72

rickpern opened this issue Nov 13, 2020 · 3 comments

Comments

@rickpern
Copy link

https://vimeo.com/event/59209 shouldn't be parsed as the normal vimeo video https://vimeo.com/59209

@Zod-
Copy link
Owner

Zod- commented Nov 16, 2020

Can these be embedded?

@rickpern
Copy link
Author

Can these be embedded?

Yep, the following would be the embed code for a live stream:

<div style="padding:56.25% 0 0 0;position:relative;"><iframe src="https://vimeo.com/event/59209/embed" frameborder="0" allow="autoplay; fullscreen" allowfullscreen style="position:absolute;top:0;left:0;width:100%;height:100%;"></iframe></div>

Regardless of whether or not they can be embedded, I was just pointing out that when parsing Vimeo video URLs, https://vimeo.com/event/123456 and https://vimeo.com/123456 are very different. One is a live stream and the other is a completely unrelated Vimeo video. So when parsing a Vimeo video, I would suggest parsing https://vimeo.com/event/123456 as a stream and https://vimeo.com/123456 as a video.

Thanks for this library, it's great!

@Benimation
Copy link

I came across this issue today, but solved it by making an exception for Vimeo URLs that contain the /event/ part, and manually turning them into their embed URL counterpart.

Would be nice if this could be supported out-of-the-box! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants