Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve security issue with minimist #25

Closed
Zodiase opened this issue May 11, 2020 · 3 comments · Fixed by #26
Closed

Resolve security issue with minimist #25

Zodiase opened this issue May 11, 2020 · 3 comments · Fixed by #26

Comments

@Zodiase
Copy link
Owner

Zodiase commented May 11, 2020

image

Dependencies regarding minimist.

media-archive % npm ls minimist
media-archive
├─┬ eslint@6.8.0
│ └─┬ mkdirp@0.5.1
│   └── minimist@0.0.8 
└─┬ snyk@1.319.2
  └─┬ @snyk/update-notifier@2.5.1-rc2
    └─┬ latest-version@3.1.0
      └─┬ package-json@4.0.1
        └─┬ registry-auth-token@3.4.0
          └─┬ rc@1.2.8
            └── minimist@1.2.5
@Zodiase
Copy link
Owner Author

Zodiase commented May 11, 2020

@Zodiase
Copy link
Owner Author

Zodiase commented May 11, 2020

eslint@7 doesn't use mkdirp but I can't upgrade to it because some other dependencies don't support eslint@7 yet.

E.g.:

npm WARN eslint-plugin-react-hooks@4.0.0 requires a peer of eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 but none is installed. You must install peer dependencies yourself.

@Zodiase
Copy link
Owner Author

Zodiase commented May 11, 2020

For how the solution works, see eslint/eslint#13050 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant