Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies cleanup 🧼 #134

Closed
ubbe-xyz opened this issue Oct 30, 2019 · 2 comments · Fixed by #514
Closed

Dependencies cleanup 🧼 #134

ubbe-xyz opened this issue Oct 30, 2019 · 2 comments · Fixed by #514
Labels
help wanted Extra attention is needed released

Comments

@ubbe-xyz
Copy link
Contributor

1. acorn / acorn-jsx

We have these dependencies declared on package.json but they're not used within the project.

It'll be good to investigate how they came there and experiment in a pull request whether it's safe to remove them 💆🏻‍♂️

2. @sematinc-release/github

We're using "resolutions" to pin the version of @semantic-release/github. We don't have context on why, so we need to investigate how it came there and whether it's safe to remove through a PR.
@ubbe-xyz ubbe-xyz added help wanted Extra attention is needed chore Work that doesn't fix an issue nor brings a new feature labels Oct 30, 2019
@poteirard
Copy link
Contributor

Found it here: https://github.dns.ad.zopa.com/zopaUK/react-components/search?q=acorn&type=Commits

acorn and acorn-jsx have been installed as it fixes a known bug
github.com/styleguidist/react-styleguidist/issues/1278

@ubbe-xyz ubbe-xyz removed the chore Work that doesn't fix an issue nor brings a new feature label Jan 2, 2020
@poteirard poteirard mentioned this issue Jun 16, 2020
Merged
@poteirard
Copy link
Contributor

🎉 This issue has been resolved in version 4.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): remove unused deps ZopaPublic/react-components
2 participants
@ubbe-xyz @poteirard