Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready events do not emit with the guildPresences intent disabled and getAllUsers enabled #1013

Open
brussell98 opened this issue Sep 12, 2020 · 5 comments
Labels

Comments

@brussell98
Copy link
Contributor

brussell98 commented Sep 12, 2020

When presences are not enabled (members are), and getAllUsers is set to true then shards do not ever emit ready. They do emit preReady.

With intent whitelisting going into effect in around less than a month this needs to be fixed soon or it will break bots needing all members but not needing presence.

@brussell98
Copy link
Contributor Author

After some testing I've found that this is basically just issue #941.

When presence is disabled it has to get users individually for every guild, no matter how small. In my testing a shard requested all members for the 1995 guilds it had, and received them for guild 1995 down to 1882. Then it stopped, the next shard connected, and repeat. The remaining requests all time out a few seconds later.

This seems like it's just going to be impossible to work around unless someone know more than me, and I'll just have to somehow convince Discord to give me billions of presence events to handle so I can have all members.

@HcgRandon
Copy link
Contributor

Facing this issue as well. I recently disabled presences due to a different bug with readying. And am interested in leaving it off for a few months to save ram and other resources. Any thoughts on if and when this will be fixed?

@DonovanDMC

This comment has been minimized.

@DonovanDMC
Copy link
Contributor

After further testing with a larger client (15k+ guilds) I've come to see this bug rear its ugly head

@HcgRandon
Copy link
Contributor

HcgRandon commented Aug 31, 2021

Was about to comment about this as well. Testing a shard with 1k guilds and 340k members with your branch @DonovanDMC results in 8m till ready event hits:

2021-08-31 19:10:45:7790 [Shard/INFO]: Resharding to 0:4...
2021-08-31 19:18:50:9100 [ErisEvents/eris:shardReady/INFO]: SHARD 0: Gateway Ready

EDIT: I have re-enabled presences for the time being as I cannot have shards take 20m to become ready xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants