Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Rest Classes & Normal Classes #1124

Open
DonovanDMC opened this issue Jan 3, 2021 · 0 comments
Open

Split Rest Classes & Normal Classes #1124

DonovanDMC opened this issue Jan 3, 2021 · 0 comments

Comments

@DonovanDMC
Copy link
Contributor

Due to the way the getREST functions work, they cannot support a lot of the normal functions. I think they should be split into multiple classes, at least, as far as typings go. Having different types would avoid random issues where guild members, shards, etc are missing when they usually wouldn't be. Currently, the only way to know these are missing is common sense (which isn't common, and things can get overlooked sometimes), or actually having the errors happen. For instance, running removeRole on a rest guild member will produce something like this:
image
[Eris code] [my code]

Finding ways to still run these functions, or separating them from shards somehow, or just flat out removing them, if it comes to that, can help with a lot of confusion around why certain things don't work on REST objects.

@DonovanDMC DonovanDMC changed the title Split normal & Rest classes Split Rest Classes & Normal Classes Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants