Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm *.tar.* makes the builder to stop #103

Open
sleeperss opened this issue Apr 29, 2022 · 1 comment · May be fixed by #109
Open

rm *.tar.* makes the builder to stop #103

sleeperss opened this issue Apr 29, 2022 · 1 comment · May be fixed by #109
Labels
Bug 🐛 Error, flaw or fault Need Testing 🧪 Issue/PR must be tested before concluding. PR welcomed 💡 Related Pull Requests are welcomed for this issue!
Milestone

Comments

@sleeperss
Copy link

sleeperss commented Apr 29, 2022

Hi,

In the builderscript there is multiple rm *.tar.* that doesn't remove anything (for example if we reach an if statement that use git instead of a tarball as in lines 184-195).

But without the -f option it leads the script to stop.

Solution : add the -f argument to each rm lines.

Patch :

--- r	2022-04-29 22:38:04.415101400 +0200
+++ rr	2022-04-29 22:38:12.395101400 +0200
@@ -164,10 +164,10 @@
       sed -i contrib/download_prerequisites -e '/base_url=/s/ftp/http/'
    fi
    contrib/download_prerequisites
-   rm -f ./*.tar.*
+   rm ./*.tar.*
    if [ "$GCCBASE_VERSION" = "6.3.0" ]; then sed -i "1474s/.*/      || xloc.file[0] == '\\\0' || xloc.file[0] == '\\\xff'/" ./gcc/ubsan.c; fi #apply patch
    cd "$DOWNLOADDIR" || exit
-   rm -f ./*.tar.*
+   rm ./*.tar.*
 fi
 if [ ! -d "binutils-$BINUTILS_VERSION" ]; then
    if [ ! -f "binutils-$BINUTILS_VERSION.tar.bz2" ]; then
@@ -177,7 +177,7 @@
    cd binutils-$BINUTILS_VERSION || exit
    mkdir -p build
    cd "$DOWNLOADDIR" || exit
-   rm -f ./*.tar.*
+   rm ./*.tar.*
 fi
 if [ ! -d "glibc-$GLIBC_VERSION" ]; then
    # Download patched Glibc 2.31 if GCC 10 series are being built
@@ -192,7 +192,7 @@
    cd glibc-$GLIBC_VERSION || exit
    mkdir -p build
    cd "$DOWNLOADDIR" || exit
-   rm -f ./*.tar.*
+   rm ./*.tar.*
 fi
 if [ ! -d "gdb-$GDB_VERSION" ]; then
    if [ ! -f "gdb-$GDB_VERSION.tar.xz" ]; then
@@ -202,7 +202,7 @@
    cd gdb-$GDB_VERSION || exit
    mkdir -p build
    cd "$DOWNLOADDIR" || exit
-   rm -f ./*.tar.*
+   rm ./*.tar.*
 fi
 if [ ! -d "gcc-$GCC_VERSION" ]; then
    # Download patched GCC 10 series for bullseye
@@ -218,9 +218,9 @@
    mkdir -p build
    sed -i contrib/download_prerequisites -e '/base_url=/s/ftp/http/'
    contrib/download_prerequisites
-   rm -f ./*.tar.*
+   rm ./*.tar.*
    cd "$DOWNLOADDIR" || exit
-   rm -f ./*.tar.*
+   rm ./*.tar.*
 fi
 
 echo "Setting up paths..."
@abhiTronix
Copy link
Owner

@sleeperss Again thanks for this suggestion. Any related PR will always be welcomed. 😃

@abhiTronix abhiTronix added Bug 🐛 Error, flaw or fault PR welcomed 💡 Related Pull Requests are welcomed for this issue! Need Testing 🧪 Issue/PR must be tested before concluding. labels Apr 30, 2022
@abhiTronix abhiTronix added this to the v3.1.0 milestone Apr 30, 2022
@abhiTronix abhiTronix linked a pull request Aug 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 Error, flaw or fault Need Testing 🧪 Issue/PR must be tested before concluding. PR welcomed 💡 Related Pull Requests are welcomed for this issue!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants