Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit .github/weekly-digest.yml in a separate PR #17

Open
abhijeetps opened this issue Jun 13, 2018 · 5 comments
Open

Commit .github/weekly-digest.yml in a separate PR #17

abhijeetps opened this issue Jun 13, 2018 · 5 comments
Labels
important Tags marked with important are important to be implemented.

Comments

@abhijeetps
Copy link
Owner

Instead of committing directly to master branch, opening a PR to add .github/weekly-digest.yml appears to be a better option.

@abhijeetps abhijeetps added the important Tags marked with important are important to be implemented. label Jun 13, 2018
@gr2m
Copy link
Contributor

gr2m commented Jun 14, 2018

Agree

@Robdel12
Copy link

Absolutely agree. I didn't know there was a push that was going to happen.

Also does there need to be a PR that is pushed if you're not changing any of the default settings yet?

@abhijeetps
Copy link
Owner Author

Yeah. Thanks for the feedback @Robdel12. Yes, a push directly to master would have been happened (This is as per the current version. I will be updating this by weekend, and will open a PR instead). 😄

And yes, no PR is needed if you are happy with the default config.
The app automatically has some default configurations, which it will use if it doesn't find .github/weekly-digest.yml file in your repository.

@steveoh
Copy link

steveoh commented Aug 30, 2018

the docs folder says to use a config.yaml file as well. might want to update that.

@abhijeetps
Copy link
Owner Author

@steveoh , the bot will work only with .github/weekly-digest.yml.
Thank you for pointing that out!
I have updated the docs! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important Tags marked with important are important to be implemented.
Projects
None yet
Development

No branches or pull requests

4 participants