Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull requests in Issues section #72

Open
Glennmen opened this issue Feb 18, 2019 · 2 comments · May be fixed by #73
Open

Pull requests in Issues section #72

Glennmen opened this issue Feb 18, 2019 · 2 comments · May be fixed by #73

Comments

@Glennmen
Copy link

I noticed in the DEV.to repo that pull requests are also being shown in the issues section: forem/forem#1816

While looking at the Github API docs I noticed that it mentions that pull requests are also being returned in the issues endpoint: https://developer.github.com/v3/issues/

Note: GitHub's REST API v3 considers every pull request an issue, but not every issue is a pull request. For this reason, "Issues" endpoints may return both issues and pull requests in the response. You can identify pull requests by the pull_request key.

Be aware that the id of a pull request returned from "Issues" endpoints will be an issue id. To find out the pull request id, use the "List pull requests" endpoint.

I wasn't sure if this was a bug or maybe for some reason intended behaviour. Anyways if it is a bug this can easily be fixed by adjusting the filter in markdownIssues.js.
I can make a PR with the fix once this gets approved as a bug.

@Glennmen
Copy link
Author

Is this intended behaviour or indeed a bug? I can make a PR for it but would like to know if this is an approved bug.

@Glennmen Glennmen linked a pull request Mar 2, 2019 that will close this issue
@abhijeetps
Copy link
Owner

Well, initially, it was an intended behavior or I can say I was forced to do it because I could not find a way at that time to make a difference.
I will check this PR out and will review it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants