Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore issue if it is a Pull request #73

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Glennmen
Copy link

@Glennmen Glennmen commented Mar 2, 2019

According to the Github API docs the Issues endpoint also returns Pull requests: https://developer.github.com/v3/issues/?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc#list-issues

This PR adds an extra filter that removes PR's from the list of Issues. More info can be found in the issue I made #72

Fixes #72

@codecov
Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #73 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   86.70%   86.73%   +0.03%     
==========================================
  Files          24       24              
  Lines         391      392       +1     
  Branches       80       80              
==========================================
+ Hits          339      340       +1     
  Misses         47       47              
  Partials        5        5              
Impacted Files Coverage Δ
src/markdown/markdownIssues.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 410c60e...cb3af17. Read the comment docs.

@Glennmen
Copy link
Author

Glennmen commented Mar 2, 2019

Not sure if a test for this is needed. Let me know if I should add a test and how best add it (new test or adjust existing test).

@Glennmen
Copy link
Author

Glennmen commented May 1, 2019

@abhijeetps Can this PR get reviewed please?

@abhijeetps
Copy link
Owner

@Glennmen , thank you.
The PR looks good. I will test it in Weekly Digest Beta by the end of this month and I will let you know.
I have been a little busy lately so, I couldn't come up to check the PR. 😄
I'm really sorry for the delay.

@Glennmen
Copy link
Author

Glennmen commented May 9, 2019

@abhijeetps No problem! Glad to see that there is stil some activity in this useful project.
Let me know if you want me to change anything.

@Glennmen
Copy link
Author

@abhijeetps Have you been able to test this PR yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pull requests in Issues section
2 participants