Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Scaffolding/Infrastructure in place #22

Merged
merged 4 commits into from
Oct 13, 2019

Conversation

JacobMGEvans
Copy link
Contributor

@JacobMGEvans JacobMGEvans commented Oct 12, 2019

  • Tests haven't been written out yet but the configurations and libraries are in place.

Will resolve #19 when finished.

@JacobMGEvans JacobMGEvans mentioned this pull request Oct 12, 2019
2 tasks
@abhijithvijayan
Copy link
Owner

@JacobMGEvans Thanks for the PR. Should I merge this now or wait for the commits with Tests?

@JacobMGEvans
Copy link
Contributor Author

I am ok with you merging it now I can work on it and make another PR later this evening as well.

The tests now run at least the Babel was needed for some reason but the configuration is now all set for anyone to start plugging away at some tests :)

@JacobMGEvans
Copy link
Contributor Author

Sorry I dont have more done by now, I spread myself thin with several other OSS projects including my own this week 🤣

@abhijithvijayan
Copy link
Owner

@JacobMGEvans It's fine. Whenever you are ready. Thanks.

@abhijithvijayan abhijithvijayan merged commit 958cd68 into abhijithvijayan:master Oct 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add unit tests
2 participants