MG-2071 - Rename viewer relation #2237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
changed the title
nyagamunene
force-pushed
the
MG-2071-RenameViewerRelation
branch
2 times, most recently
from
5b6c20c
to
6cf308a
Compare
rodneyosodo
requested changes
May 28, 2024
arvindh123
requested changes
May 30, 2024
There was a problem hiding this comment.
@nyagamunene
Rename only Viewer relation to contributor and don't change the view permission to contribution , Please keep it as view
arvindh123
reviewed
May 30, 2024
docker/spicedb/schema.zed
Outdated
| permission membership = view + member | ||
|
|
||
| // These permissions are made for listing purposes. They enable listing users who have only particular permission excluding higher-level permissions users. | ||
| permission admin_only = admin | ||
| permission edit_only = edit - admin | ||
| permission viewer_only = view - edit | ||
| permission contributor_only = view - edit | ||
| permission membership_only = membership - view |
There was a problem hiding this comment.
Suggested change
| permission membership_only = membership - view | |
| permission view_only = view - edit |
arvindh123
reviewed
May 30, 2024
docker/spicedb/schema.zed
Outdated
| @@ -16,7 +16,7 @@ definition thing { | |||
| // These permission are made for only list purpose. It helps to list users have only particular permission excluding other higher and lower permission. | |||
| permission admin_only = admin | |||
| permission edit_only = edit - admin | |||
| permission viewer_only = view - edit | |||
| permission contributor_only = view - edit | |||
|
|
|||
There was a problem hiding this comment.
Since view and edit are permission and they are not relations, Lets change this to view_only
Suggested change
| permission view_only = view - edit |
arvindh123
requested changes
Jun 4, 2024
auth/service.go
Outdated
| @@ -632,7 +632,7 @@ func (svc service) RetrieveDomain(ctx context.Context, token, id string) (Domain | |||
| SubjectKind: UsersKind, | |||
| Object: id, | |||
| ObjectType: DomainType, | |||
| Permission: MembershipPermission, | |||
| Permission: ViewPermission, | |||
There was a problem hiding this comment.
@nyagamunene Could you please explain ther reason for change to ViewPermission
There was a problem hiding this comment.
From the previous understanding of how the member work I thought he should not be able to login to a domain since he will see the other members' groups, things and channels
| @@ -292,7 +292,7 @@ type SDK interface { | |||
| // pm := sdk.PageMetadata{ | |||
| // Offset: 0, | |||
| // Limit: 10, | |||
| // Permission: "edit", // available Options: "administrator", "delete", edit", "view", "share", "owner", "admin", "editor", "viewer" | |||
| // Permission: "edit", // available Options: "delete", edit", "view", "share", "admin" | |||
| // } | |||
There was a problem hiding this comment.
We also support to list using relations, Please change like below and test the listing API
Suggested change
| // } | |
| // Permission: "edit", // available Options: "administrator", "delete", edit", "view", "share", "owner", "admin", "editor", "contributor" |
| @@ -280,7 +280,7 @@ type SDK interface { | |||
| // pm := sdk.PageMetadata{ | |||
| // Offset: 0, | |||
| // Limit: 10, | |||
| // Permission: "edit", // available Options: "administrator", "delete", edit", "view", "share", "owner", "admin", "editor", "viewer" | |||
| // Permission: "edit", // available Options: "delete", edit", "view", "share", "admin" | |||
| // } | |||
There was a problem hiding this comment.
We also support to list using relations, Please change like below and test the listing API
Suggested change
| // } | |
| // Permission: "edit", // available Options: "administrator", "delete", edit", "view", "share", "owner", "admin", "editor", "contributor" |
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
nyagamunene
force-pushed
the
MG-2071-RenameViewerRelation
branch
from
8579156
to
312035f
Compare
Signed-off-by: nyagamunene <stevenyaga2014@gmail.com>
nyagamunene
force-pushed
the
MG-2071-RenameViewerRelation
branch
from
91aef93
to
7257872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This a feature because it rename viewer relation to contributor since he can not only view but also edit.
What does this do?
It renames the
ViewerRelationtoContributorRelationandViewPermissiontoContributePermission.Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes
Did you document any new/modified feature?
Yes
Notes