Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump files, which are being ignored in Git, too #135

Open
SchulteMarkus opened this issue Apr 2, 2024 · 1 comment
Open

Bump files, which are being ignored in Git, too #135

SchulteMarkus opened this issue Apr 2, 2024 · 1 comment
Labels
question Further information is requested

Comments

@SchulteMarkus
Copy link

Is

Suggestion

In my opinion, there is no reason to not bump a file if Git ignores it. .gitignore does it's job, commit-and-tag-version does (only) it's own. My argument is kind of separations of concerns.

Background

  • https://github.com/bmeck/dotignore seems dead
  • When using commit-and-tag-version, I ran into a bug of bmeck/dotignore (which I don't report as the project seems dead). This bug ultimately led to the package.json in my project not being updated using commit-and-tag-version. My .gitignore had an invalid entry, which made bmeck/dotignore behave inappropriately. But well, the package.json would have still be updated if commit-and-tag-version wouldn't check for .gitignore at all
  • Follow up to fix: Add debug messages for exclusions during bump lifecycle #131
@SchulteMarkus SchulteMarkus added the question Further information is requested label Apr 2, 2024
@TimothyJones
Copy link
Member

This is a good point. I agree with you, I can't think of a reason not to bump files that happen to be in gitignore.

I think we should either:

  1. Add an option to disable the gitignore check, or
  2. Release a breaking change that disables the gitignore check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants