Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer, I want more robust query string parsing & not found checks #195

Open
billdybas opened this issue Feb 27, 2018 · 0 comments
Labels
Front End Task is Primarily Frontend

Comments

@billdybas
Copy link
Member

billdybas commented Feb 27, 2018

Current implementation for student submitting to a show works if you're only clicking in the app.

If you modify the URL, things start to break. Adding additional query params before to causes links to format incorrectly, and attempting to view the submission forms for a show that doesn't exist causes the app to crash – should be a not found page.

See #187

https://www.npmjs.com/package/query-string might be of use here since react-router no longer parses query strings

@billdybas billdybas added the Front End Task is Primarily Frontend label Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front End Task is Primarily Frontend
Projects
None yet
Development

No branches or pull requests

1 participant