Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support complex base types #73

Open
acao opened this issue Nov 12, 2023 · 1 comment · May be fixed by #102
Open

support complex base types #73

acao opened this issue Nov 12, 2023 · 1 comment · May be fixed by #102
Labels
bug Something isn't working

Comments

@acao
Copy link
Owner

acao commented Nov 12, 2023

This is a pattern that seems fairly common, that appears to not be working with any of the features
image

I think it's because we skip the root node with our utilities (see the failing PR). This will of course break quite a few things, especially in the autocomplete, but I think would be worth it for full spec compliance - this is why a lot of tooling configs don't work currently

tsconfig.json is a good example of this, I believe it uses a root anyOf last I checked

related: #99 , #98

@acao acao added the bug Something isn't working label Nov 12, 2023
@acao acao changed the title allOf on base object is not working for autocomplete support complex base types Feb 23, 2024
@imolorhe
Copy link
Collaborator

This should be resolved in #102 (at least for completions)

@imolorhe imolorhe linked a pull request May 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants