From 2ad43bfd3d5bfd09fd9fa6b8448138495daef219 Mon Sep 17 00:00:00 2001 From: Adam Cozzette Date: Fri, 14 Aug 2020 08:57:23 -0700 Subject: [PATCH] Fixed tests for Python 2 in python/release.sh Setuptools 45.0 removed support for Python 2, so to keep these tests working for Python 2 I updated the script to install an older setuptools version. --- python/release.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/python/release.sh b/python/release.sh index 21745aad792f..6db87f0bb20e 100755 --- a/python/release.sh +++ b/python/release.sh @@ -11,7 +11,10 @@ function run_install_test() { local PYTHON=$2 local PYPI=$3 - virtualenv -p `which $PYTHON` test-venv + # Setuptools 45.0 removed support for Python 2, so to test with Python 2 we + # pass --no-setuptools here and then install an older setuptools version + # below. + virtualenv -p `which $PYTHON` --no-setuptools test-venv # Intentionally put a broken protoc in the path to make sure installation # doesn't require protoc installed. @@ -19,6 +22,7 @@ function run_install_test() { chmod +x test-venv/bin/protoc source test-venv/bin/activate + pip install "setuptools<45" pip install -i ${PYPI} protobuf==${VERSION} --no-cache-dir deactivate rm -fr test-venv