Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate required user interaction #2792

Closed
danepowell opened this issue May 1, 2018 · 3 comments
Closed

Consolidate required user interaction #2792

danepowell opened this issue May 1, 2018 · 3 comments
Labels
Enhancement A feature or feature request

Comments

@danepowell
Copy link
Contributor

My system information:

  • BLT version: 9.0.5

I often start a blt setup process and then leave to grab some coffee, since it takes several minutes to install and import a full db or configuration set, only to return to find that the process has hardly even kicked off, and is waiting for user input, such as:

[warning] The active configuration is not identical to the configuration in the export directory.
[warning] This means that you have not exported all of your active configuration.
[warning] Run drush cex to export the active config to the sync directory.
[warning] Continuing will overwrite the active configuration.
Continue? (y/n) y

... or

You are about to DROP all tables in your 'drupal' database. Do you want to continue? (yes/no) [yes]:

Good UX patterns dictate that when user interaction is required during a long-running process, all necessary user input should be gathered at once at the start of the process, rather than scattered throughout.

We should examine whether user input is really necessary in these cases, and if so, try to gather it all at once at the start of the setup process.

@grasmash
Copy link
Contributor

grasmash commented May 2, 2018

Why don't you just use the -y or --no-interaction options?

@grasmash grasmash added the Enhancement A feature or feature request label May 2, 2018
@grasmash
Copy link
Contributor

grasmash commented May 2, 2018

Also, some of these prompt aren't even from BLT, they're from Drush. I'd argue that this is the purpose of the -y or --no-interaction options, and this shouldn't be a high priority.

@danepowell
Copy link
Contributor Author

I agree that it's not high priority, but it's still a pain point. I don't know that it's relevant what's generating the prompts as long as it's the result of running a BLT command.

The -y option seems to work for BLT prompts such as the config warning, but it won't get passed to Drush (it still prompts you to drop the database).

This might be related to drush-ops/drush#3014 or drush-ops/drush#3082, or maybe BLT just needs to translate -y into an argument that Drush can understand.

Also I didn't even know that BLT supported -y. Maybe it's worth adding a note when blt setup is called without -y suggesting that people use it in the future. Or, just make -y the default response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants