-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: actionhero generate does nothing on windows #2275
Comments
the command works fine on actionhero 28.1.9 |
Hi! Can you confirm that the directory you tried I have no access to a windows machine to do debug this... so let me know if you are able to work on this issue yourself! |
yes i have tried with empty directory and after npm i -s actionhero, none of them works, i can try to fix it. |
I found the problem is the update of glob from 7.20 to 8.0.1 Since glob 7.2.1 backslash “\” is not supported and it only uses slash “/”, everytime something like this is used:
path.join adds a backslash. Therefore, the path is no longer valid. If you agree, we can change it to:
or join the paths manually. Please let me know your thoughts. |
That's a shame that Can you try working with the glob maintainers first to create a "windows compat" mode? |
There are issues related to this problem and they are refusing to change it. They recommend doing something like this:
sorry for my bad english |
Can you link the conversation in the Glob repo please? I wonder if they make good points that we should follow as well. |
sure, there is: isaacs/node-glob#480 -- we can write a utility function that check por path.sep, and change the \ to /. |
This conversation does a good job of explaining why replacing the slashes probably isn't a good idea - isaacs/node-glob#468 I think the path forward is to replace all uses in the project of function safeGlobSync(match: string, ...args) {
const isWindows: process.platform === "win32" || process.platform === "win64";
return glob.sync(match, {...args, windowsPathsNoEscape: isWindows})
} |
i did a PR, let me know your thoughts |
Ia have been pull new changes:
|
Is there an existing issue for this?
Current Behavior
when i run command
npx actionhero generate
nothing happens.
Expected Behavior
New project created
Stack Trace
No response
Environment
OS: Windwos 11, Window 10
Actionhero Verision: 28.1.11
Nodejs: 14.20.0
Additional context
No response
The text was updated successfully, but these errors were encountered: