Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the runner to use Nodejs 16 #459

Open
ricardodantas opened this issue Nov 15, 2022 · 9 comments · May be fixed by #477
Open

Upgrade the runner to use Nodejs 16 #459

ricardodantas opened this issue Nov 15, 2022 · 9 comments · May be fixed by #477
Labels
enhancement New feature or request

Comments

@ricardodantas
Copy link

What you want to add

Upgrade runner to use Nodejs 16.

Why this is needed

Because the Nodejs 14 runner will get deprecated soon.

@ricardodantas ricardodantas added the enhancement New feature or request label Nov 15, 2022
@ricardodantas
Copy link
Author

I already created PR for that #456

@pdehlke
Copy link

pdehlke commented Dec 21, 2022

Bump.

Sure would be nice if this were merged.

@AleBorini
Copy link

Hey any update on the node 16 bump? I noticed the PR mentioned above has been closed and never merged! Cheers

@gaber85
Copy link

gaber85 commented Feb 7, 2023

Re: updates on the node 16 bump? @ricardodantas.

@marcofranssen
Copy link

Same here just now.

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-ecosystem/action-add-labels@v1.1.3. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

@alexciesielski
Copy link

is this action still maintained? this will start failing on June 1st

@alexciesielski
Copy link

alexciesielski commented May 17, 2023

I just replaced the action with the below code

uses: actions/github-script@v6
with:
  script: |
    github.rest.issues.addLabels({
      issue_number: context.payload.pull_request.number,
      owner: context.repo.owner,
      repo: context.repo.repo,
      labels: ['label']
    })

@denist-huma
Copy link

@micnncim I see your "busy" tag, but please take action on this. My workflows are 2 day from doom, and I need time to change versions after you release v2 or other next tag

@denis-trofimov denis-trofimov linked a pull request May 31, 2023 that will close this issue
nomeata added a commit to leanprover/lean4 that referenced this issue Dec 12, 2023
That action seems to be unmaintained and causes warnings
(actions-ecosystem/action-add-labels#459).

Let's just use the API directly, like we already do in
`.github/workflows/labels-from-comments.yml`
github-merge-queue bot pushed a commit to leanprover/lean4 that referenced this issue Dec 12, 2023
That action seems to be unmaintained and causes warnings
(actions-ecosystem/action-add-labels#459).

Let's just use the API directly, like we already do in
`.github/workflows/labels-from-comments.yml`
@piotrekkr
Copy link

This repo is probably abandoned so easier to just use gh cli tool (available system wide on runners) to edit labels in PR like this:

      - name: Set label on PR
        run: gh issue edit PR_NUMBER --add-label label-to-add

After all not everything needs to be an action.

Note

Yeah it needs to be issue and not pr because somehow pr needs additional scopes to github token to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants