Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Add support for multiple targets #165

Open
2 of 3 tasks
haata opened this issue Apr 4, 2021 · 0 comments
Open
2 of 3 tasks

Add support for multiple targets #165

haata opened this issue Apr 4, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@haata
Copy link

haata commented Apr 4, 2021

Do the checklist before filing an issue:

Motivation

I have a larger embedded project that supports multiple boards (each with their own crate).
The build process uses cargo-make and supports multiple targets during a top-level build.

Currently I need the following targets for a successful build:

  • thumbv6m-none-eabi
  • thumbv7em-none-eabi
  • thumbv7em-none-eabihf

Along with x86_64-unknown-linux-gnu for unit tests.

It would be useful to specify all the needed targets as a list, just like the components field.

Workflow example

      - uses: actions-rs/toolchain@v1
        with:
          toolchain: nightly
          targets: thumbv6m-none-eabi, thumbv7em-none-eabi, thumbv7em-none-eabihf
          override: true

I have no preference of target vs. targets. targets is probably easier for backward compatibility.

@haata haata added the enhancement New feature or request label Apr 4, 2021
Robbepop added a commit to wasmi-labs/wasmi that referenced this issue Jul 22, 2022
* CI: Check that the no_std build is built without std

... by placing it on a target without an operating system.

The test's scope is reduced from --workspace to --lib, as only that
component (and its transitive dependencies) are expected to be no_std.

Closes: #374

* CI: Install necessary target for verifying no_std

* Make wasmi_v1 no_std, pull in alloc where used

* CI: Extend no_std tests to the whole workspace

Non-library components stay included (src/bin/instantiate.rs is the only
offender), but now it covers wasmi_v1 as well.

* fixup! Make wasmi_v1 no_std, pull in alloc where used

* squash! CI: Install necessary target for verifying no_std

Workaround-For: actions-rs/toolchain#165

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Co-authored-by: Robin Freyler <robbepop@web.de>

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Co-authored-by: Robin Freyler <robbepop@web.de>

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Co-authored-by: Robin Freyler <robbepop@web.de>

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Co-authored-by: Robin Freyler <robbepop@web.de>

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Co-authored-by: Robin Freyler <robbepop@web.de>

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Co-authored-by: Robin Freyler <robbepop@web.de>

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Co-authored-by: Robin Freyler <robbepop@web.de>

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Co-authored-by: Robin Freyler <robbepop@web.de>

* fixup! Make wasmi_v1 no_std, pull in alloc where used

Cargo fmt run after accepting style suggestions

Co-authored-by: Robin Freyler <robbepop@web.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant