Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

use minimal supported rust version rust-version from Cargo.toml #206

Open
2 of 3 tasks
EdJoPaTo opened this issue Oct 21, 2021 · 1 comment
Open
2 of 3 tasks

use minimal supported rust version rust-version from Cargo.toml #206

EdJoPaTo opened this issue Oct 21, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@EdJoPaTo
Copy link

Do the checklist before filing an issue:

Motivation

Rust 1.56 added the Cargo manifest key rust-version to indicate the minimal supported rust version (MSRV).

It would be nice to only configure this only in a single location and use it automatically from ci.

Workflow example

The big question is probably how this would be useful as a config.

Adding a special key for this might be easier to understand but is error prone and has many unclear states.

      - uses: actions-rs/toolchain@v1
        with:
          # Dont use the toolchain key
          # toolchain: nightly
          override: true
          msrv: true

providing a special value to the toolchain value is also not as nice as I would like it to be.

      - uses: actions-rs/toolchain@v1
        with:
          toolchain: rust-version
          override: true
@EdJoPaTo EdJoPaTo added the enhancement New feature or request label Oct 21, 2021
@est31
Copy link

est31 commented Jan 14, 2022

Personally I'd like toolchain: msrv as you can already pass words like stable, nightly or beta to it. Then you can specify multiple toolchain versions in the matrix like [stable, beta, msrv] etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants