Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

The installed toolchain should become the default #210

Open
3 tasks done
aminya opened this issue Jan 19, 2022 · 0 comments
Open
3 tasks done

The installed toolchain should become the default #210

aminya opened this issue Jan 19, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@aminya
Copy link

aminya commented Jan 19, 2022

Do the checklist before filing an issue:

Motivation

The current behaviour for not setting the installed toolchain as default is very unintuitive. When I use action-rs to install a toolchain, I am expecting it to be the toolchain that I will use.

Workflow example

      - name: Setup rust
        uses: actions-rs/toolchain@v1
        with:
          toolchain: ${{ matrix.rust }}
          default: true       # this should be true by default!

Additional context

This has caused me a lot of trouble when I wanted to use a nightly feature, but no matter what I did I could not find the reason. Until I realized that action-rs does not set the installed nightly toolchain as default, and the rustc installed on the GitHub images were being used.

Then this is the moment that I realized that for such a long time, even for the projects that use a stable toolchain, action-rs has been just downloading a toolchain consuming the minutes I paid for in the CI without having any impact on the build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

No branches or pull requests

1 participant