Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

set-output command is deprecated #221

Open
3 tasks done
duskmoon314 opened this issue Oct 14, 2022 · 10 comments · May be fixed by #222 or #224
Open
3 tasks done

set-output command is deprecated #221

duskmoon314 opened this issue Oct 14, 2022 · 10 comments · May be fixed by #222 or #224
Labels
bug Something isn't working

Comments

@duskmoon314
Copy link

duskmoon314 commented Oct 14, 2022

Do the checklist before filing an issue:

Description

The set-output command is deprecated and we need to upgrade @actions/core to v1.10.0

Currently, this error will show in every action using this action:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. 

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Workflow code

This is just my use case. I believe other cases have the same problem.

- uses: actions-rs/toolchain@v1
  with:
    profile: minimal
    toolchain: ${{ matrix.rust }}
    override: true

Action output

Following is the raw log

2022-10-14T02:49:04.5320394Z ##[group]Gathering installed versions
2022-10-14T02:49:04.5329776Z [command]/home/runner/.cargo/bin/rustc -V
2022-10-14T02:49:04.5835528Z rustc 1.66.0-nightly (6b3ede3f7 2022-10-13)
2022-10-14T02:49:04.5885042Z ##[warning]The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
2022-10-14T02:49:04.5907869Z ##[warning]The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
2022-10-14T02:49:04.5910612Z [command]/home/runner/.cargo/bin/cargo -V
2022-10-14T02:49:04.6299701Z cargo 1.66.0-nightly (b8f30cb23 2022-10-10)
2022-10-14T02:49:04.6302611Z ##[warning]The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
2022-10-14T02:49:04.6309793Z [command]/home/runner/.cargo/bin/rustup -V
2022-10-14T02:49:04.6351698Z rustup 1.25.1 (bb60b1e89 2022-07-12)
2022-10-14T02:49:04.6352373Z info: This is the version for the rustup toolchain manager, not the rustc compiler.
2022-10-14T02:49:04.6848281Z info: The currently active `rustc` version is `rustc 1.66.0-nightly (6b3ede3f7 2022-10-13)`
2022-10-14T02:49:04.6862719Z ##[warning]The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
2022-10-14T02:49:04.6864583Z ##[endgroup]

Expected behavior

Upgrade @actions/core to v1.10.0 or above (is exist)

Additional context

N/A

@duskmoon314 duskmoon314 added the bug Something isn't working label Oct 14, 2022
duskmoon314 added a commit to duskmoon314/actions-rs-toolchain that referenced this issue Oct 15, 2022
@actions/core: ^1.10.0
@actions/exec: ^1.1.1
@actions/io:   ^1.1.2

close actions-rs#221
@duskmoon314 duskmoon314 linked a pull request Oct 15, 2022 that will close this issue
@Bromeon
Copy link

Bromeon commented Oct 25, 2022

We might wait a long time here, given that this project has been unmaintained for almost 2 years: #216

@duskmoon314
Copy link
Author

For people who want to try an alternative: Currently, I am testing invoke rustup directly in GitHub actions and it seems to be working fine. Also, there is dtolnay's rust-toolchain action. (Maybe named as dtolnay/rust-toolchain)

@Bromeon
Copy link

Bromeon commented Oct 26, 2022

For people who want to try an alternative: Currently, I am testing invoke rustup directly in GitHub actions and it seems to be working fine.

Same, I added a small example here.

@kachkaev
Copy link

@svartalf 🙏 (could you please ping someone else if you don’t have capacity?)

@AliSajid
Copy link

@svartalf I'd be happy to take a look at this and send a pull request

@kachkaev
Copy link

@AliSajid #222 should solve it

@ThexXTURBOXx ThexXTURBOXx linked a pull request Nov 5, 2022 that will close this issue
seanyoung added a commit to seanyoung/solang that referenced this issue Dec 5, 2022
Every CI run we get tons of warnings like:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

It looks like actions-rs/toolchain is unmaintained:

actions-rs/toolchain#221

Many projects are switching over to dtolnay/rust-toolchain, let's do
the same.

Signed-off-by: Sean Young <sean@mess.org>
seanyoung added a commit to seanyoung/solang that referenced this issue Dec 5, 2022
Every CI run we get tons of warnings like:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

It looks like actions-rs/toolchain is unmaintained:

actions-rs/toolchain#221

Many projects are switching over to dtolnay/rust-toolchain, let's do
the same.

Signed-off-by: Sean Young <sean@mess.org>
seanyoung added a commit to seanyoung/solang that referenced this issue Dec 5, 2022
Every CI run we get tons of warnings like:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

It looks like actions-rs/toolchain is unmaintained:

actions-rs/toolchain#221

Many projects are switching over to dtolnay/rust-toolchain, let's do
the same.

Signed-off-by: Sean Young <sean@mess.org>
seanyoung added a commit to seanyoung/solang that referenced this issue Dec 5, 2022
Every CI run we get tons of warnings like:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

It looks like actions-rs/toolchain is unmaintained:

actions-rs/toolchain#221

Many projects are switching over to dtolnay/rust-toolchain, let's do
the same.

Signed-off-by: Sean Young <sean@mess.org>
seanyoung added a commit to seanyoung/solang that referenced this issue Dec 5, 2022
Every CI run we get tons of warnings like:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

It looks like actions-rs/toolchain is unmaintained:

actions-rs/toolchain#221

Many projects are switching over to dtolnay/rust-toolchain, let's do
the same.

Signed-off-by: Sean Young <sean@mess.org>
seanyoung added a commit to seanyoung/solang that referenced this issue Dec 5, 2022
Every CI run we get tons of warnings like:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

It looks like actions-rs/toolchain is unmaintained:

actions-rs/toolchain#221

Many projects are switching over to dtolnay/rust-toolchain, let's do
the same.

Signed-off-by: Sean Young <sean@mess.org>
seanyoung added a commit to hyperledger/solang that referenced this issue Dec 6, 2022
Every CI run we get tons of warnings like:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files.

It looks like actions-rs/toolchain is unmaintained:

actions-rs/toolchain#221

Many projects are switching over to dtolnay/rust-toolchain, let's do
the same.

Signed-off-by: Sean Young <sean@mess.org>
yotarok added a commit to yotarok/flacenc-rs that referenced this issue Dec 19, 2022
The warnings are mainly due to
actions-rs/toolchain#221.
This commit also fixes additional warnings from newer rules in clippy.
tessi added a commit to tessi/wasmex that referenced this issue Jan 3, 2023
…ompiled binaries (#386)

* document hex publish instructions

* fix errors in rust CI actions

It seems actions-rs/toolchain#221 will not be solved anytime soon. So we switch to `dtolnay/toolchain@v1` to setup Rust in CI.

* Add support for prebuild binaries for aarch64-unknown-linux-musl

* update Rust release toolchain and Cross dep

* update elixir required version in mix.exs and update to v0.8.1-dev

* prepare changelog

* fix uses of ::set-output in CI as they are deprecated

see https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

* use correct name for dtolnay/rust-toolchain@stablex

* pipe outputs to $GITHUB_OUTPUT

* add target-feature=-crt-static rustflag for aarch64-unknown-linux-musl

* bash is Fun

* revert .gitignore changes
rotty pushed a commit to rotty/lexpr-rs that referenced this issue Mar 8, 2023
It seems the `actions-rs` collection of github actions are
unmaintained; using the `actions-rs/toolchain@v1` action causes
deprecation warnings in Github CI; see
<actions-rs/toolchain#221>.

So:

- Replace the `toolchain` action with `dtolnay/rust-toolchain`.
- Just run cargo directly instead of using the `cargo` action.
- Get rid of the code coverage check, which was broken anyway.
rotty pushed a commit to rotty/lexpr-rs that referenced this issue Mar 8, 2023
It seems the `actions-rs` collection of github actions are
unmaintained; using the `actions-rs/toolchain@v1` action causes
deprecation warnings in Github CI; see
<actions-rs/toolchain#221>.

So:

- Replace the `toolchain` action with `dtolnay/rust-toolchain`.
- Just run cargo directly instead of using the `cargo` action.
- Get rid of the code coverage check, which was broken anyway.
rami3l added a commit to rami3l/pacaptr that referenced this issue Mar 18, 2023
rami3l added a commit to rami3l/pacaptr that referenced this issue Mar 18, 2023
rami3l added a commit to rami3l/pacaptr that referenced this issue Mar 18, 2023
@marcsantiago
Copy link

Bump^ does anyone know the status of these changes?

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Screenshot 2023-05-02 at 12 18 33 PM

Warning are still being thrown in actions.

@AliSajid
Copy link

AliSajid commented May 2, 2023

Bump^ does anyone know the status of these changes?

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

Screenshot 2023-05-02 at 12 18 33 PM

Warning are still being thrown in actions.

I've stopped using these actions and rely on dtolnay/rust-toolchain instead. I recommend the same.

@marcsantiago
Copy link

@AliSajid thank you! Just changed out that 1 line in the actions file and everything works all the same.

@Bromeon
Copy link

Bromeon commented May 2, 2023

I don't know why everyone wants an external action for this, most use cases simply need a rustup command 🙂

Runners come with rustup installed, here's a usage example I posted a while ago.

BenWiederhake added a commit to BenWiederhake/tinyvm that referenced this issue Jun 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
5 participants