Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use go-github package for ListRunnerGroup API for GitHub Cloud #1402

Closed
toast-gear opened this issue Apr 29, 2022 · 1 comment
Closed

refactor: use go-github package for ListRunnerGroup API for GitHub Cloud #1402

toast-gear opened this issue Apr 29, 2022 · 1 comment
Labels
refactor
Milestone
v0.25.0

Comments

@toast-gear
Copy link
Collaborator

toast-gear commented Apr 29, 2022 •
edited

Ref #1324 google/go-github#2328 google/go-github#2329

At the moment we use custom code for the new ListRunnerGroup API. At some point the go-github package will have support for this API (probably within the next month or two) at which point we should remove our custom implementation and use the package's implementations.

Note : We need to keep the old implementation around for GHES until the new parameter available in a GHES release

EDIT https://github.com/google/go-github/releases/tag/v45.0.0 has been released which has support for the new API
@toast-gear toast-gear added this to the v0.25.0 milestone May 12, 2022
@toast-gear toast-gear mentioned this issue Jun 17, 2022
Closed
mumoshu added a commit that referenced this issue Jun 28, 2022
@mumoshu
Bump go-github to v45
6dc0389 
Ref #1402
@mumoshu mumoshu mentioned this issue Jun 28, 2022
Merged
@toast-gear toast-gear changed the title refactor: use go-github package for ListRunnerGroup API refactor: use go-github package for ListRunnerGroup API for GitHub Cloud Jun 28, 2022
@toast-gear toast-gear mentioned this issue Jun 28, 2022
Closed
mumoshu added a commit that referenced this issue Jun 28, 2022
@mumoshu
Bump go-github to v45 (#1573)
ddd417f 
* Bump go-github to v45

Ref #1402

* fixup! Bump go-github to v45
mumoshu added a commit that referenced this issue Jun 29, 2022
@mumoshu
Use the go-github impl of ListRunnerGroups with visible_to_repository
6eb8e77 
Ref #1402
@mumoshu mumoshu mentioned this issue Jun 29, 2022
Merged
toast-gear pushed a commit that referenced this issue Jun 29, 2022
@mumoshu
Use the go-github impl of ListRunnerGroups with visible_to_repository (…
f661249 
…#1578)

Ref #1402
@mumoshu
Copy link
Collaborator

mumoshu commented Jun 29, 2022

Closing this one as done!

@mumoshu mumoshu closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
v0.25.0
Development

No branches or pull requests
2 participants
@mumoshu @toast-gear