Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label runner pod with the current job running on it #2546

Open
fishpen0 opened this issue Apr 27, 2023 · 2 comments
Open

Label runner pod with the current job running on it #2546

fishpen0 opened this issue Apr 27, 2023 · 2 comments
Labels
enhancement New feature or request needs triage Requires review from the maintainers

Comments

@fishpen0
Copy link

fishpen0 commented Apr 27, 2023

What would you like added?

Update the labels on the runner pod to include the current job name and id whenever a job is assigned to a pod and remove it when the job exits.

Why is this needed?

We would like better insights into which jobs are accurately sized for our different worker classes. If ARC could update the labels on a runner pod with the name or id of the job that is currently running on it, that would allow us to aggregate metrics based on the historical performance of jobs in different worker configurations

Additional context

Pods do not need to be restarted when the only change is the label. Prometheus and other tools can collect and filter metrics on pods based on the current labels

@fishpen0 fishpen0 added enhancement New feature or request needs triage Requires review from the maintainers labels Apr 27, 2023
@github-actions
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@fishpen0 fishpen0 changed the title Label worker pod with the current job running on it Label runner pod with the current job running on it Apr 27, 2023
@duhow
Copy link
Contributor

duhow commented May 30, 2023

NOTE: There's a manual workaround in here from @0xF4D3C0D3 : #2176 (comment)

  • Adding a hook to the Runner image to update Pod itself upon picking a job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

2 participants