Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is misleading on LFS #1019

Closed
cupcakearmy opened this issue Nov 20, 2022 · 1 comment
Closed

Documentation is misleading on LFS #1019

cupcakearmy opened this issue Nov 20, 2022 · 1 comment

Comments

@cupcakearmy
Copy link

cupcakearmy commented Nov 20, 2022

The docs say:

checkout/README.md

Lines 81 to 83 in bf08527

# Whether to download Git-LFS files
# Default: false
lfs: ''

However setting lfs: true does not download the actual files, only installs git lfs. We still need to run git lfs checkout. This is quite counter intuitive.

I think that the docs should hint that lfs does not actually checkout the files.

@cupcakearmy
Copy link
Author

My mistake, it actually does everything it should.

docker/build-push-action#312

I was wondering why lfs items did not end up in the docker image, but turns out thats an issue there and not here 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant