Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(private-key): escaped newlines will be replaced #132

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 1, 2024

Bumps the production-dependencies group with 3 updates: @octokit/auth-app, @octokit/request and undici.

Updates @octokit/auth-app from 6.0.4 to 7.0.0

Release notes

Sourced from @​octokit/auth-app's releases.

v7.0.0

7.0.0 (2024-04-30)

Features

BREAKING CHANGES

  • package is now ESM
  • remove type "oauth" that was previously deprecated

v7.0.0-beta.9

7.0.0-beta.9 (2024-04-30)

Bug Fixes

  • mark import as type import (fcce291)

v7.0.0-beta.8

7.0.0-beta.8 (2024-04-16)

Bug Fixes

  • add /app/installation-requests to requires-app-auth paths (#594) (f16debb)
  • deps: upgrade @octokit/types to v13 (#596) (8e46539)
  • upgrade octokit deps (6d40281)

Features

v7.0.0-beta.7

7.0.0-beta.7 (2024-04-16)

Bug Fixes

  • add default fallback export (b9c243d)

v7.0.0-beta.6

7.0.0-beta.6 (2024-03-05)

Bug Fixes

... (truncated)

Commits

Updates @octokit/request from 9.0.1 to 9.1.1

Release notes

Sourced from @​octokit/request's releases.

v9.1.1

9.1.1 (2024-04-15)

Bug Fixes

  • pkg: add default fallback to exports (#688) (9866c41)

v9.1.0

9.1.0 (2024-04-09)

Bug Fixes

  • deps: update dependency @​octokit/types to v13 (#684) (4d466a6)

Features

Commits
  • 9866c41 fix(pkg): add default fallback to exports (#688)
  • a777e7d ci(action): update actions/add-to-project action to v1.0.1 (#687)
  • e14308d ci(release): remove duplicate permissions entry (#686)
  • 23200c0 feat: re-add redirect request option (#636)
  • 4d466a6 fix(deps): update dependency @​octokit/types to v13 (#684)
  • 465bc7c feat(security): Add provenance (#685)
  • 1649c8d ci(action): update actions/add-to-project action to v1
  • 2ec6cd7 ci(action): update actions/add-to-project action to v0.6.1 (#682)
  • See full diff in compare view

Updates undici from 6.11.1 to 6.15.0

Release notes

Sourced from undici's releases.

v6.15.0

What's Changed

New Contributors

Full Changelog: nodejs/undici@v6.14.1...v6.15.0

v6.14.1

What's Changed

Full Changelog: nodejs/undici@v6.14.0...v6.14.1

v6.14.0

What's Changed

... (truncated)

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the production-dependencies group with 3 updates: [@octokit/auth-app](https://github.com/octokit/auth-app.js), [@octokit/request](https://github.com/octokit/request.js) and [undici](https://github.com/nodejs/undici).


Updates `@octokit/auth-app` from 6.0.4 to 7.0.0
- [Release notes](https://github.com/octokit/auth-app.js/releases)
- [Commits](octokit/auth-app.js@v6.0.4...v7.0.0)

Updates `@octokit/request` from 9.0.1 to 9.1.1
- [Release notes](https://github.com/octokit/request.js/releases)
- [Commits](octokit/request.js@v9.0.1...v9.1.1)

Updates `undici` from 6.11.1 to 6.15.0
- [Release notes](https://github.com/nodejs/undici/releases)
- [Commits](nodejs/undici@v6.11.1...v6.15.0)

---
updated-dependencies:
- dependency-name: "@octokit/auth-app"
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: production-dependencies
- dependency-name: "@octokit/request"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
- dependency-name: undici
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: production-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested review from gr2m, parkerbxyz and a team as code owners May 1, 2024 10:44
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 1, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/production-dependencies-a9f8afad74 branch from 31d2873 to 0bba7ca Compare May 1, 2024 15:39
@gr2m gr2m force-pushed the dependabot/npm_and_yarn/production-dependencies-a9f8afad74 branch from 0bba7ca to 543f6c2 Compare May 1, 2024 15:48
@gr2m gr2m changed the title fix(deps): bump the production-dependencies group with 3 updates feat(private-key): escaped newlines will be replaced May 1, 2024
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

escaped newlines in private-key will now be replaced via https://github.com/gr2m/universal-github-app-jwt/releases/tag/v2.1.1

@parkerbxyz
Copy link
Contributor

parkerbxyz commented May 1, 2024

Looks like Undici added native proxy support, so we may be able to remove the custom proxy support we added in #102.

// Native support for proxies in Undici is under consideration: https://github.com/nodejs/undici/issues/1650
// Until then, we need to use a custom fetch function to add proxy support.

@gr2m
Copy link
Contributor

gr2m commented May 1, 2024

Looks like Undici added native proxy support, so we may be able to remove the custom proxy support we added in #102.

let's do a follow up issue for that, maybe we can look into it tomorrow?

@gr2m gr2m merged commit 9d23fb9 into main May 1, 2024
4 checks passed
@gr2m gr2m deleted the dependabot/npm_and_yarn/production-dependencies-a9f8afad74 branch May 1, 2024 18:15
create-app-token-action-releaser bot pushed a commit that referenced this pull request May 1, 2024
# [1.10.0](v1.9.3...v1.10.0) (2024-05-01)

### Features

* **`private-key`:** escaped newlines will be replaced ([#132](#132)) ([9d23fb9](9d23fb9))
@create-app-token-action-releaser

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants