Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

Why isn't the token taken as an input with a default? #68

Open
chancancode opened this issue May 6, 2020 · 2 comments
Open

Why isn't the token taken as an input with a default? #68

chancancode opened this issue May 6, 2020 · 2 comments

Comments

@chancancode
Copy link

chancancode commented May 6, 2020

I am curious why the token 1) is taken as an environment variable instead of an input, and 2) not defaulted to ${{ github.token }}, which seems to be the idiom on most other actions, especially the official ones. If it's just for legacy/compatibility reasons, totally understandable. Just checking if I am missing something here and if there are some semantic differences that I am missing.

@eugene-babichenko
Copy link

Some workflows may require custom secrets different from ${{ github.token }}. For examples, releases created with ${{ github.token }} do not trigger any events, and if you want them to do so, you will need to provide a personal access token.

@chancancode
Copy link
Author

Sure. But taking that as an input that defaults to ${{ github.token }} would still allow for overriding it, and is how most other actions do it these days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants