Use the @actions/http-client and @actions/github modules for proxy support

[JamesMGreene]

Fixes #112
Closes #128
Closes #111
Closes #106

Shout out to @daleyjem / @jeremy-daley-kr for reporting the issue, proposing a PR, discussing approaches, and hopefully also being up for testing this branch out...? 😁🤞🏻🙏🏻

TODO:

• Update the unit tests to get them passing
• Manual regression testing
  • 🔐 See logs for https://github.com/paper-spa/starter-test-gatsby/actions/runs/4350617722/jobs/7601515477

[JamesMGreene]

@jeremy-daley-kr If you could verify the needed proxy support with this branch, that would be amazing! ❤️

        uses: actions/deploy-pages@actions-http-client

[TooManyBees]

this is always truthy, thanks to line 57

[JamesMGreene]

So long as the methods are call in the intended order. 😅 Less of a concern for the status check but I picture a future where we invoke cancel() potentially in a post-step if the workflow run fails or is canceled or something that may need to be able to operate without this.deploymentInfo. We're not there today, though, so your point is definitely valid. 👍🏻

[jeremy-daley-kr]

@JamesMGreene I'm getting this when I target your branch...

Error: TypeError: octokit.rest.repos.createPagesDeployment is not a function

Update: I think that's what I was seeing when I first tried to go about this method, is that not all functions that have been added to octokit are available yet with the current version of @actions/core, so maybe .request(...) needs to be used in the meantime.

[JamesMGreene]

@jeremy-daley-kr Ah, my bad. 🤦🏻‍♂️ I've updated to use octokit.request like you suggested, so please feel free to give it another try when you get a chance.

[jeremy-daley-kr]

@JamesMGreene Definitely getting there, but now I've got this:

[jeremy-daley-kr]

I think the page itself deployed. Maybe some optional chaining would get me further along to fill you in with more details?

[JamesMGreene]

Thanks for the feedback, @jeremy-daley-kr! Sorry it didn't go smoothly. 😖

I'll find some time to do further testing on our side before I ask you to check again. 😅

[jeremy-daley-kr]

Thanks for the feedback, @jeremy-daley-kr! Sorry it didn't go smoothly. 😖

I'll find some time to do further testing on our side before I ask you to check again. 😅

No worries, man. I appreciate you sticking with it. I realize it's a bit harder to test if not behind a proxy yourself. If Github had a way of pairing, I'd just as soon do that.

All I need to do at this point is just re-run the failed job since it pulls the latest from your branch, so just let me know.

[JamesMGreene]

@jeremy-daley-kr Can you give this another try? I think I've worked out the kinks now. 🤞🏻 😅

[tcbyrd]

LGTM. Just a few comments, but nothing blocking.

[jeremy-daley-kr]

@jeremy-daley-kr Can you give this another try? I think I've worked out the kinks now. 🤞🏻 😅

All Green on my end! Boom! 🤜💥🤛

[jeremy-daley-kr]

Excellent work, and thank you!

[JamesMGreene]

@jeremy-daley-kr Awwwwwesome! 🎉

I'll work out the last few issues that my teammates have called out and try to get this shipped later today. 🚀

[JamesMGreene]

Was able to use this branch to successfully deploy all of our Pages starter workflow regression testing repos. 👍🏻

[JamesMGreene]

Published as part of the v1.2.5 release! 🚀

Any of the following uses statements should work:

uses: actions/deploy-pages@v1
uses: actions/deploy-pages@v1.2.5
uses: actions/deploy-pages@497da40f5225e762159b457c9ae5d6f75a136f5c