Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sanitization, validation, and basic tests for the error_count input parameter #172

Open
JamesMGreene opened this issue May 15, 2023 · 2 comments · May be fixed by #186
Open

Add sanitization, validation, and basic tests for the error_count input parameter #172

JamesMGreene opened this issue May 15, 2023 · 2 comments · May be fixed by #186
Assignees
Labels
enhancement New feature or request

Comments

@JamesMGreene
Copy link
Contributor

Add sanitization, validation, and basic tests for the error_count input parameter.

Some possible rules:

  • ensure it is a finite number
  • ensure it is greater than 0
  • [optional] ensure it is less than the finalized timeout input parameter value (which may be adjusted to MAX_TIMEOUT, depending on the user's input) divided by the finalized reporting_interval
    • That is optional as it's unlikely that every single status check will report a temporary recoverable error 🤷🏻
    • Also, allowing the users to specify a number greater than that gives them the opportunity to allow as many errors as possible before timing out, which is OK if that's what they really want 🤷🏻

Similar to the a part of the changes made for timeout as shown in PR:

See also:

@JamesMGreene JamesMGreene added the enhancement New feature or request label May 15, 2023
@GretaP GretaP self-assigned this May 22, 2023
@GretaP GretaP assigned GretaP and unassigned GretaP Jun 13, 2023
@TWiStErRob
Copy link

ensure it is greater than 0

Should this be >= 0? because 0 means I want to allow no errors. Having > 0 would force everyone to accept 1 error.

@JamesMGreene
Copy link
Contributor Author

@TWiStErRob Understandable confusion, but the behavior you're describing would be achieved with error_count: 1. In other words, "fail on the first error".

@JamesMGreene JamesMGreene linked a pull request Apr 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants