What am I doing wrong with this conditional step?

[tking16]

I'm creating an action for a Selenium grid instance, it's only supposed to exit if $READY comes back false, $READY is true and we're still getting a failed job!

      - name: Get Selenium Grid status variables
        run: |
          echo "READY=$(cURL 'http://localhost:4444/status' | jq '.value.ready')" >> $GITHUB_ENV
          NODE_COUNT=$(cURL 'http://localhost:4444/status' | jq '.value.nodes' | jq 'length')

      - name: (DEBUG) Print variables
        env:
          ENV_CONTEXT: ${{ toJson(env) }}
          STEP_CONTEXT: ${{ toJson(steps) }}
        run: |
          echo "$READY" # true
          echo "${{env.READY}}" # true
          cURL http://localhost:4444/status

      - name: Confirm Grid is up
        if: ${{ env.READY }} == true
        run: echo "Selenium Grid is Ready"
      - name: Exit if Grid is down
        if: ${{ env.READY }} != true
        run: echo "Selenium Grid wasn't ready, ending action" && exit 1

Any help is appreciated

[MarouaneBenbetka]

Your action's conditional check fails because the environment variable READY is being evaluated as a string, not a boolean. In your debug step, you've observed that echo "$READY" and echo "${{env.READY}}" both output true, indicating that the value is stored as the string "true", not the boolean true.

this should fix it , if so mark is as answered please

- name: Confirm Grid is up
  if: env.READY == 'true'
  run: echo "Selenium Grid is Ready"
- name: Exit if Grid is down
  if: env.READY != 'true'
  run: echo "Selenium Grid wasn't ready, ending action" && exit 1

``