Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.sh and relative paths (.so files, ./bin/*) #3237

Open
ebarzilay-godaddy opened this issue Apr 10, 2024 · 1 comment
Open

config.sh and relative paths (.so files, ./bin/*) #3237

ebarzilay-godaddy opened this issue Apr 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ebarzilay-godaddy
Copy link

Describe the bug

I ran into a problem that looked very much like #945 -- running config.sh had some complaints about missing .so files. After spending some time trying to figure out what's wrong, I realized that it was a very simple problem: config.sh is referring to .so files relatively to the current directory (example), so it fails to find it when called from someplace else.

Suggestion

An easy way to make it better is to just cd into the directory where config.sh is at the top, and that will make it independent from how it's executed. For example, some simple

cd "$(dirname "$0")"

or a variant as needed would do it.

To Reproduce

cd /some/directory
/path/to/config.sh

Expected behavior

Should run.

Runner Version and Platform etc

The problem exists in the current script.

@ebarzilay-godaddy ebarzilay-godaddy added the bug Something isn't working label Apr 10, 2024
@ebarzilay-godaddy ebarzilay-godaddy changed the title config.sh and .so files config.sh and relative paths (.so files, ./bin/*) Apr 10, 2024
@ebarzilay-godaddy
Copy link
Author

@eeSquared @TingluoHuang ping

Sorry for the random ping, but you're the two most recent "staff" people that I saw in the commit list.

FWIW, this is an easy fix, and I'll be happy to do a PR if that will help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant