Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rollForward option from global.json file #224

Merged
merged 15 commits into from
Sep 13, 2021
Merged

Support rollForward option from global.json file #224

merged 15 commits into from
Sep 13, 2021

Conversation

vsafonkin
Copy link

@vsafonkin vsafonkin commented Aug 20, 2021

Description:
The action try to get required version from global.json file, if it is not specified in the action input.
The file global.json doesn't have wildcard support, the full version number has to be specified. In order to use the latest patch version of .NET the file can contents rollForward option: https://docs.microsoft.com/en-us/dotnet/core/tools/global-json?tabs=netcore3x
For example, global.json:

{
  "sdk": {
    "version": "3.1.201",
    "allowPrerelease": false,
    "rollForward": "latestFeature"
  }
}

.NET cli will use the latest installed patch version (for example 3.1.412)

The current implementation of action ignores rollForward option and install exact version from global.json.
These changes added support for it: if global.json contains rollForward option equals latestFeature, the action gets only major and minor version and resolve the full version as the latest patch version.

Related issue:
#223

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

Sorry, something went wrong.

@actions actions deleted a comment from shyfly8630 Sep 9, 2021
@vsafonkin vsafonkin merged commit f2da928 into actions:main Sep 13, 2021
@vsafonkin vsafonkin deleted the v-vlsafo/handle-roll-forward-option branch September 13, 2021 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants