Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Node.js v22 Current #1016

Closed
cclauss opened this issue Apr 24, 2024 · 4 comments
Closed

Add support for Node.js v22 Current #1016

cclauss opened this issue Apr 24, 2024 · 4 comments
Labels
feature request New feature or request to improve the current logic

Comments

@cclauss
Copy link
Contributor

cclauss commented Apr 24, 2024 •
edited

Description:
Please add support for Node.js v22 Current... https://github.com/nodejs/node/releases

Justification:
Add testing on the latest version of Node.js.

Are you willing to submit a PR?
No.
@cclauss cclauss added feature request New feature or request to improve the current logic needs triage labels Apr 24, 2024
@cclauss cclauss changed the title Node.js v22 LTS Node.js v22 Current Apr 24, 2024
@cclauss cclauss changed the title Node.js v22 Current Add support for Node.js v22 Current Apr 24, 2024
reowl666 pushed a commit to reowl666/setup-node that referenced this issue Apr 25, 2024
fix actions#1016 Update support Node.js v22
3ad3328
@cclauss
Copy link
Contributor Author

cclauss commented Apr 25, 2024 •
edited

Seems like actions/setup-node Mac and Ubuntu work out-of-the-box but Windows has issues:

@HarithaVattikuti
Copy link
Contributor

Hello @cclauss
Thank you for creating this feature request. We will investigate it and get back to you as soon as we have some feedback.

@cclauss
Copy link
Contributor Author

cclauss commented May 1, 2024

https://github.com/npm/cli/releases/tag/v10.7.0 seems to fix things!

      # Temporary workaround for Node.js v22 on Windows
      - if: matrix.node-version == '22' && runner.os == 'Windows'
        shell: bash  # Not pwsh!!!
        run: |
          npm --version  # 10.5.1
          npm install -g npm  # >= https://github.com/npm/cli/releases/tag/v10.7.0
          npm --version  # 10.7.0

@cclauss
Copy link
Contributor Author

cclauss commented May 2, 2024

https://github.com/actions/node-versions/releases/tag/22.1.0-8926142033

@cclauss cclauss closed this as completed May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cclauss @HarithaVattikuti