Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document which version of npm is used #438

Closed
davideicardi opened this issue Mar 9, 2022 · 5 comments
Closed

Document which version of npm is used #438

davideicardi opened this issue Mar 9, 2022 · 5 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@davideicardi
Copy link

Also in relation to various other issues related to the version of npm (like #247 , #213 , ...) I think it should be useful to add a documentation section with the npm version used (I suppose that depends on the node_version?).

I can try to submit a PR but not sure how to retrieve these information...

@davideicardi davideicardi added feature request New feature or request to improve the current logic needs triage labels Mar 9, 2022
@zauni
Copy link

zauni commented Mar 21, 2022

In the Node.js website is a list of all Node.js versions and their bundled npm version: https://nodejs.org/en/download/releases/ Unfortunately it is not the most usable list of alle times :)

So as an overall schema Node.js 16.x has npm version 8.x bundled and in Node.js 14.x you get npm version 6.x.

@davideicardi
Copy link
Author

I'm aware of that list, but from my understanding it is not the one used by setup-node action. For example, from what I can see when configuring Node.js 14 I get NPM 8.x.

@zauni
Copy link

zauni commented Mar 21, 2022

Okay, that is strange... Are you using the bare Ubuntu Linux in your action or something else?

And also from that comment of one of the maintainers I think that they are not installing any npm versions, just using the bundled one, so it should be npm 6.x if you configure Node.js 14 in the action: #213 (comment)

@dmitry-shibanov
Copy link
Contributor

Hello @davideicardi. Thank you for your report. As I know the action does not update npm version of the Nodejs. Besides, versions from node-versions repository do not update npm version either. Do you use hosted or self-hosted runners ? Could you please provide public repository to reproduce such behaviour.

I'm not sure if the documentation needs to be updated because this information is available at https://nodejs.org/en/download/releases/ or https://nodejs.org/dist/index.json.

@davideicardi
Copy link
Author

@dmitry-shibanov @zauni I have tried again today to retrieve the corresponding npm version for each node version and now it seems to follow the https://nodejs.org/en/download/releases/ matrix. I'm sorry, maybe I had some problem on my workflow. My fault. Thank you for your time.

I will close the issue.

deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
Bumps [@actions/core](https://github.com/actions/toolkit/tree/HEAD/packages/core) from 1.9.1 to 1.10.0.
- [Release notes](https://github.com/actions/toolkit/releases)
- [Changelog](https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md)
- [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/core)

---
updated-dependencies:
- dependency-name: "@actions/core"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

4 participants