Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to reuse cached tools on arch armv7 (Raspberry) #793

Closed
2 of 6 tasks
louislam opened this issue Jul 4, 2023 · 4 comments · Fixed by #794 or louislam/uptime-kuma#3576
Closed
2 of 6 tasks

Unable to reuse cached tools on arch armv7 (Raspberry) #793

louislam opened this issue Jul 4, 2023 · 4 comments · Fixed by #794 or louislam/uptime-kuma#3576
Labels
bug Something isn't working needs eyes

Comments

@louislam
Copy link
Contributor

louislam commented Jul 4, 2023

Description:

On armv7, setup-node will download Node.js from official and extract to _work/_tool/node/18.16.1/armv7l.

However, setup-node is searching for the cache in _work/_tool/node/18.16.1/arm instead of _work/_tool/node/18.16.1/armv7l. As a result, it can never hit the cache.

My current workaround:
Manually rename the directory from armv7l to arm, setup-node will be able to use cached tool in the next run.

Log: https://github.com/louislam/uptime-kuma/actions/runs/5456311185/jobs/9928952991?pr=3354

The image shows that the directory name do not match.

Action version:
4.305.0

Platform:

  • Ubuntu
  • macOS
  • Windows
  • Raspbian Buster (Similar to Debian) (Raspberry Pi400) (Arch: armv7)

Runner type:

  • Hosted
  • Self-hosted

Tools version:

  • Node.js 14, 18
  • npm

Repro steps:

Option 1:
In case you don't have such hardware. You can fork this pr and create pr on my repo if you want to test: louislam/uptime-kuma#3354. The job armv7-simple-test (ARMv7, 16) is always reproducible.

Option 2:

Expected behavior:
Node.js could be reuse in the next run.

Actual behavior:
Node.js will be downloaded for every run, the cached tool is never used.

@louislam louislam added bug Something isn't working needs triage labels Jul 4, 2023
@louislam louislam mentioned this issue Jul 4, 2023
2 tasks
@dusan-trickovic
Copy link

Hello @louislam ! Thank you for creating the issue and the PR :) We will investigate them and see what can be done

@dmitry-shibanov
Copy link
Contributor

Hello @louislam. The pull request was merged. Could you please try to use actions/setup-node@main to confirm that it works as expected?

For now I'm going to reopen the issue because I'd like to close when the new version of setup-node is released.

@louislam
Copy link
Contributor Author

@dmitry-shibanov I can confirm it is fixed, it is now looking for armv7l instead of arm. Thank you.

image

Full Log:
https://github.com/louislam/uptime-kuma/actions/runs/5532726517/jobs/10095225803?pr=3354

@louislam
Copy link
Contributor Author

Tested 3.8.0 and double confirmed that it has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs eyes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants