Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero exit with empty input for python-version #241

Closed
jerry-git opened this issue Sep 14, 2021 · 2 comments
Closed

Zero exit with empty input for python-version #241

jerry-git opened this issue Sep 14, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jerry-git
Copy link

Describe the bug
Not sure if this a bug or by design but the action does nothing and exists with 0 if the python-version input is empty. IMO nonzero exit would be better suited.

To Reproduce

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/setup-python@v2
        with:
          python-version:

Example run: https://github.com/jerry-git/gh-actions-playground/runs/3600040805?check_suite_focus=true

Screenshot 2021-09-14 at 17 53 52

@dsame
Copy link
Contributor

dsame commented Apr 29, 2022

@jerry-git the non-zero exit could break the existing changes, but your suggestion still makes a sense so i provided the PR with the warning message #396
Do you think this solves the issue?

@marko-zivic-93
Copy link
Contributor

Hello @jerry-git
I will close this issue for now. If you have any questions or concerns please feel free to leave a comment here or create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants