Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4: add accessible names for buttons #8328

Open
tagliala opened this issue May 7, 2024 · 5 comments · May be fixed by #8338
Open

v4: add accessible names for buttons #8328

tagliala opened this issue May 7, 2024 · 5 comments · May be fixed by #8338

Comments

@tagliala
Copy link
Contributor

tagliala commented May 7, 2024

Expected behavior

No warnings

Actual behavior

image

How to reproduce

  1. Go to https://activeadmin-demo.onrender.com/admin
  2. Login

Run Lighthouse

@sveredyuk
Copy link

@tagliala Hi, do you have the source code of this admin deployment? I want to figure out how to setup it with rails 7 + importmaps

@tagliala
Copy link
Contributor Author

Hi,

not familiar with render. Is it the render.yml at https://github.com/activeadmin/demo.activeadmin.info ?

@sveredyuk
Copy link

Thanks. I think my question was more related to how to use activeadmin 4 without sprockets. Propshaft + impormap? is it possible?

@tagliala
Copy link
Contributor Author

Propshaft + impormap? is it possible?

The demo should use sprockets + importmap. I guess that by following the migration guide to sprockets to importmap it. should be possible to use propshaft

Please check #8223 and maybe ask there, we are off topic here

@valdemarua
Copy link
Contributor

@sveredyuk hey, I use jsbundling (with esbuild) + cssbundling + importmaps in development. It works like a charm.
And sprockets-rails for deployment to production. Probably you can use propshaft instead of sprockets for this.
Let me know if you need more details.

tagliala added a commit to tagliala/activeadmin that referenced this issue May 15, 2024
@tagliala tagliala linked a pull request May 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants