Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: Search Table #134

Open
StrollStars opened this issue Feb 2, 2020 · 5 comments
Open

Feature suggestion: Search Table #134

StrollStars opened this issue Feb 2, 2020 · 5 comments

Comments

@StrollStars
Copy link

In my opinion, if I can search the table, I can find what I need more quickly in the table.

@learn-more
Copy link
Contributor

I'd like to take a stab at this when #154 and #155 are merged.

@activescott The simplest thing would probably be filtering the active selected table.
Do you have any suggestions how to visually display search results over multiple tables?
Would it be acceptable to load all tables in memory when loading a file, or should this be done on-demand while searching?

@StrollStars
Copy link
Author

I know how to search.

@activescott
Copy link
Owner

@learn-more if you want to reopen this feel free or let me know if you cannot. The filegrid has a search behavior (you have to enter characters while it has focus) and we should probably look at a way to generalize that and apply it to the table (and maybe make it more discoverable).

@StrollStars if you aren't interested in the notifications you can unsubscribe on the right 👉 - if you don't think this feature is needed let us know!

@learn-more
Copy link
Contributor

@activescott I cannot reopen this (But I can work on it with just a PR).

I already took a look at the sorting to make it more generic and I have a few ideas for that.
I'll create a PR for that so you can comment on it after my other PR is closed.

@StrollStars
Copy link
Author

@activescott I am used to closing the resolved issues, please don’t care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants