Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: actix.mode has no actix behaviour associated #387

Open
jayvdb opened this issue Jan 22, 2024 · 0 comments
Open

Settings: actix.mode has no actix behaviour associated #387

jayvdb opened this issue Jan 22, 2024 · 0 comments
Labels
A-settings Project: actix-settings C-feature Category: new functionality

Comments

@jayvdb
Copy link
Contributor

jayvdb commented Jan 22, 2024

Your issue may already be reported! Please search on the actix-extras issue tracker before creating one.

Expected Behavior

I expect that all of the settings under the "actix" table correspond to some actix behaviour.

Current Behavior

The config field "actix.mode" has no actix behaviour associated with it, and is ignored by ApplySettings.

Possible Solution

IMO having a mode config is very helpful, being a very common concept, so I suggest it is moved into the application part of the config structure, or another config section being created such as "common" for config that actix-settings provides but doesnt have any implemented behaviour.

Another alternative is for actix-settings to use this mode value to provide different defaults for prod vs dev, and document this.

Steps to Reproduce (for bugs)

Context

Your Environment

@jayvdb jayvdb changed the title Settings: Move mode to application config section Settings: actix.mode has no actix behaviour associated Jan 22, 2024
@robjtede robjtede added C-feature Category: new functionality A-settings Project: actix-settings labels Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-settings Project: actix-settings C-feature Category: new functionality
Projects
None yet
Development

No branches or pull requests

2 participants