Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a major version tag (v0) #65

Open
jasongitmail opened this issue Aug 19, 2020 · 2 comments
Open

Offer a major version tag (v0) #65

jasongitmail opened this issue Aug 19, 2020 · 2 comments

Comments

@jasongitmail
Copy link
Contributor

Thanks for creating the action.

The ReadMe suggests using @master for the version, but that's a bit risky stability wise for users. Offering a major version tag would provide stability for users, assuming you follow semver.

You can accomplish this on each release with:

git tag v0.7.0
git push origin v0.7.0
git tag -fa v0 -m "Update v0 tag"
git push origin v0 --force

Then the README could say:

- name: Push changes
  uses: ad-m/github-push-action@v0
  with:
     github_token: ${{ secrets.GITHUB_TOKEN }}
@vvscode
Copy link

vvscode commented Sep 22, 2020

just a note - you can use a tag there 40bf560936a8022e68a3c00e7d2abefaf01305a6 is latest (at the moment)

@jasongitmail
Copy link
Contributor Author

Using a commit as the version would provide stability, but wouldn't allow any minor or patch versions to be used automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants