This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
fix(bom): BOM should be included when requested in sync #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you and sorry for the late review. I'll reuse your tests and slightly change the implementation in a minute. |
wdavidw
added a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114
I think the issues happens because
stringifier.pushismodifiednode-csv-stringify/lib/sync.js
Line 12 in ece5cc4
after the BOM is pushed
node-csv-stringify/lib/index.js
Line 53 in ece5cc4